From 6b43d3544e3a2b92b1d7cb04c2fa046a3423eb1a Mon Sep 17 00:00:00 2001 From: kanym Date: Sat, 26 Sep 2026 14:00:21 +0200 Subject: [PATCH] feat(fenrir): say why the fire breath did not come, and log a Draugh's parry Holding right mouse as a Cultist with no eitr did nothing whatsoever - no flames, no sound, no reason given. The form arrives at Yagluth and eitr is a Mistlands thing, so a Cultist meets that silence before it ever meets the fire. It now says "Only breath comes out. The fire wants eitr." on a three-second timer, since the button is read every frame and the message would otherwise be a wall. The parry that fires the Draugh's poison splash is logged, with the block timer against the window and whether the splash effect resolved. A parry has to land inside a quarter-second window while blocking, so "nothing looks different after tier 3" is as likely to mean the window was missed as it is to mean the splash did not draw, and there was no way to tell those apart. Co-Authored-By: Claude Opus 5 --- .../Draugh/DraughProgressionPatches.cs | 9 +++++++ JotunnModStub/Fenrir/FenrirBehaviors.cs | 24 +++++++++++++++++-- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/JotunnModStub/Draugh/DraughProgressionPatches.cs b/JotunnModStub/Draugh/DraughProgressionPatches.cs index f56ce0f..105eb1b 100644 --- a/JotunnModStub/Draugh/DraughProgressionPatches.cs +++ b/JotunnModStub/Draugh/DraughProgressionPatches.cs @@ -109,6 +109,15 @@ namespace RacesOfValheim UnityEngine.Object.Instantiate(splashVfx, attacker.GetCenterPoint(), Quaternion.identity); } + // Said on every parry, which are rare enough not to be noise. A parry has + // to land inside a quarter-second window while blocking, so "nothing looks + // different" is as likely to mean the window was missed as it is to mean + // the splash did not draw - and there was no way to tell the two apart. + Jotunn.Logger.LogInfo( + $"[Draugh] Parry on '{attacker.name}': {DraughConfig.PoisonSplashDamage.Value:F0} poison, " + + $"blockTimer={blockTimer:F3} of {parryTime:F2}, " + + $"splash vfx={(splashVfx != null ? "vfx_blob_hit" : "NOT RESOLVED")}."); + // Stage 5: North Wind (AoE Frost) if (state >= 5) { diff --git a/JotunnModStub/Fenrir/FenrirBehaviors.cs b/JotunnModStub/Fenrir/FenrirBehaviors.cs index 70137f4..ef2d09c 100644 --- a/JotunnModStub/Fenrir/FenrirBehaviors.cs +++ b/JotunnModStub/Fenrir/FenrirBehaviors.cs @@ -815,9 +815,14 @@ namespace RacesOfValheim UpdateFire(); } } - else if (isShootingFire) + else { - StopFire(); + // Held with an empty pool. Until now this did nothing whatsoever: no + // flames, no sound, no reason given - and the form's own tier is Yagluth + // while eitr is a Mistlands thing, so a Cultist meets this before it ever + // meets the fire. + SayNoEitr(); + if (isShootingFire) StopFire(); } } else if (isShootingFire) @@ -883,6 +888,21 @@ namespace RacesOfValheim private GameObject fireEffectInstance; + private float lastNoEitrMessage = -100f; + + /// + /// Says why the fire did not come. Held down rather than tapped, so it is on a timer: the + /// button is read every frame and the message would otherwise be a wall. + /// + private void SayNoEitr() + { + if (Player.m_localPlayer == null || Time.time - lastNoEitrMessage < 3f) return; + + lastNoEitrMessage = Time.time; + Player.m_localPlayer.Message(MessageHud.MessageType.Center, + "Only breath comes out. The fire wants eitr."); + } + private void StartFire() { if (Player.m_localPlayer == null || isShootingFire) return;