fix(dvergur): correct the health malus, body scale and hood
Health: the malus was taken off Character.GetMaxHealth, which only made the getter lie. Character.SetMaxHealth is the one thing that clamps current health to the new maximum and it never saw a lower number, so the bar shrank while the value stayed where it was. Player.SetMaxHealth also flashes the bar whenever the new maximum is above GetMaxHealth(), so against a getter that always read low every food tick looked like an increase and re-triggered the flash. Taking the malus off Player.GetTotalFoodValue instead puts it upstream of both, and leaves Valheim to do its own clamping on an honest number. Scale: applied from the plugin MonoBehaviour, it was overwritten on the same frame by Trol's Player.Update postfix, which forced every non-Trol player back to scale 1. Sizing now happens in a postfix on that same method, the way the Trol does it, and RaceScale records which races size themselves so they stop undoing each other. This also fixes the Furling, which was losing the same race. Hood: the Dverger Circlet is a metal band, not the hood, and instantiating a skinned mesh leaves its bones pointing at the source prefab so it renders nowhere. The headgear is now lifted off the Dvergr NPC and rebound to the player's own bones by name, as the Skeleton does for whole bodies. Skin is tinted to a dvergr grey, saved and restored through the same OriginalSkinColor keys the other tinted races use. Adds a dumpdverger console command: prefab contents live in the asset bundles and cannot be read outside a running game, so this is how the hood mesh and the per-star LevelEffects colours get identified.
This commit is contained in:
parent
3ec51aeb45
commit
79a54fb533
8 changed files with 388 additions and 118 deletions
35
JotunnModStub/RaceScale.cs
Normal file
35
JotunnModStub/RaceScale.cs
Normal file
|
|
@ -0,0 +1,35 @@
|
|||
namespace RacesOfValheim
|
||||
{
|
||||
/// <summary>
|
||||
/// Which races size their own body.
|
||||
///
|
||||
/// Several races postfix Player.Update and set the player's "Visual" scale from there. Each of
|
||||
/// them also wants to undo that scale once the player is no longer of their race, and the
|
||||
/// straightforward way to write that - "if this isn't my race, force the scale back to 1" -
|
||||
/// makes every such race stamp on every other one, with the winner decided by whichever
|
||||
/// postfix Harmony happened to run last.
|
||||
///
|
||||
/// That is what left the Dvergur at full height: Trol's reset ran on the same frame and put it
|
||||
/// straight back to 1. Asking here first means a race only ever resets a player that nobody
|
||||
/// else is sizing.
|
||||
/// </summary>
|
||||
public static class RaceScale
|
||||
{
|
||||
private static readonly string[] SelfSizingRaces =
|
||||
{
|
||||
"Trol",
|
||||
"Furling",
|
||||
DvergurConfig.RaceId
|
||||
};
|
||||
|
||||
public static bool ManagesOwnScale(string race)
|
||||
{
|
||||
if (string.IsNullOrEmpty(race)) return false;
|
||||
foreach (string self in SelfSizingRaces)
|
||||
{
|
||||
if (race == self) return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue