fix(skeleton): Summon on Kill was completely dead - fix the whole chain

Queen/Fader-tier Skeletons were supposed to raise a tamed ally from every
kill, but nothing ever spawned. Several independent bugs stacked up:

- Kill attribution failed whenever the death blow was a poison DOT tick
  (SE_Poison builds its own attacker-less HitData every second, and
  Character.ApplyDamage overwrites m_lastHit on every one of those ticks).
  Since PoisonAttacks bakes bonus poison onto every Skeleton hit from
  Bonemass on, this was the common case, not an edge case. Character_Damage_Patch
  now tracks recent player hits per ZDOID as a fallback (RecentSkeletonHits),
  the same pattern Aswid's own life-drain-kill check already uses.
- SummonPrefabName pointed at "Skeleton_friendly", which isn't a real
  prefab (confirmed against the live ZNetScene registry). Reuses the
  Bound Bone Pile's own SkeletonThrall_Melee instead - tamed, loot-stripped,
  forced-melee, and already proven to work.
- The rise VFX names ("vfx_skeleton_spawn", "vfx_bloodmagic_aoe") were
  guesses that never existed either; fx_summon_skeleton_spawn is the real
  one. Same fix applied to the pre-existing Auto-Resurrect effect, which
  had the identical wrong names.
- The actual "climbing out of the ground" motion is a separate Animator
  bool ("wakeup") set via ZSyncAnimation - the exact call vanilla's own
  CreatureSpawner makes. Without it the model was simply active from
  frame one, VFX playing around a skeleton that was already standing.
- Vanilla skeletons carry no Tameable component, which spammed "is tamed
  but missing tameable or monster AI script!" every time a raised one
  landed a hit. Same fix Fenrir already uses for the Ulv and Fenring:
  copy one in from the vanilla Wolf, done once at prefab registration so
  it also quietly fixes the Bound Bone Pile's own thralls.
- Added RaisedThrall.SetExpiry(), a station-independent hard lifespan -
  these skeletons are never bound to a pile, so the existing anchor/wither
  pair had nothing to key off. Summoned skeletons now wither 2 minutes
  after being raised.

Also adds a permanent `listprefabs <substring>` debug console command -
queries the live ZNetScene registry directly, which is how the wrong
prefab/VFX names above were actually confirmed rather than guessed.
This commit is contained in:
kanym 2026-08-29 16:01:23 +02:00
commit 8c24ae3340
5 changed files with 232 additions and 12 deletions

View file

@ -47,7 +47,12 @@ namespace RacesOfValheim
// shorter and wore a 0.85/1.20/0.85 squeeze to compensate. Tied to the model, not a tier.
public static readonly UnityEngine.Vector3 FireModelScale = UnityEngine.Vector3.one;
public const string SummonPrefabName = "Skeleton_friendly";
// Reuses the Bound Bone Pile's own melee thrall (SkeletonBonePile.ThrallMeleeName) rather
// than a standalone prefab, so a Queen/Fader kill raises the same tamed, loot-stripped,
// forced-melee skeleton the pile does - not a separate, unproven asset. "Skeleton_friendly"
// was tried first and never resolved to a real prefab; see the mod's own log for the
// "no prefab in the cache" warning that caught it.
public const string SummonPrefabName = SkeletonBonePile.ThrallMeleeName;
// Fader's dead stand taller than everyone else's. Applied to the player's root transform,
// which is how this race has always sized itself - so it carries the collider, the camera