From 9287bd060d1a3e460ccbb5b5a86ea6b26a116270 Mon Sep 17 00:00:00 2001 From: kanym Date: Fri, 7 Aug 2026 11:32:13 +0200 Subject: [PATCH] fix(factions): use the real 'Goblin' prefab id, not the display name 'Fuling' FactionHostilityPatch's NeraForestaMobs set and FactionMerchantCatalog's Shops dictionary both keyed the base Goblin by its in-game display name, "Fuling", instead of its actual prefab id. Confirmed against the game's own asset paths (Assets/Characters/Goblin/, TrophyGoblin.prefab) rather than assumption - "Fuling" appears nowhere as a real prefab, only as flavor text (kept as-is on the shop's own DisplayName, which is just UI label text). Neither peace nor merchant status ever actually applied to a plain Goblin for any Black Forest race (Trenta, Trol, Furling) as a result - only the GoblinBrute/GoblinShaman entries, which already used their real ids, worked. Confirmed a related but separate bug while investigating, left alone per request: AswidRace.cs's mobToTrophyMap also keys off "Fuling" and feeds it into a live prefab lookup for food nutrition tuning - same wrong-id pattern, milder failure mode (falls back to generic values rather than breaking anything). Not fixed here. --- JotunnModStub/Factions/FactionHostilityPatch.cs | 2 +- JotunnModStub/Factions/FactionMerchantCatalog.cs | 6 +++--- JotunnModStub/Furling/FurlingPatches.cs | 4 ++-- README.md | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/JotunnModStub/Factions/FactionHostilityPatch.cs b/JotunnModStub/Factions/FactionHostilityPatch.cs index 7a20956..b23b2ae 100644 --- a/JotunnModStub/Factions/FactionHostilityPatch.cs +++ b/JotunnModStub/Factions/FactionHostilityPatch.cs @@ -20,7 +20,7 @@ namespace RacesOfValheim private static readonly HashSet NeraForestaMobs = new HashSet { "Greydwarf", "Greydwarf_Elite", "Greydwarf_Shaman", - "Fuling", "GoblinBrute", "GoblinShaman", + "Goblin", "GoblinBrute", "GoblinShaman", // "Goblin" is the real prefab id - "Fuling" is only the in-game display name "Troll", }; diff --git a/JotunnModStub/Factions/FactionMerchantCatalog.cs b/JotunnModStub/Factions/FactionMerchantCatalog.cs index 126cee9..fbc4698 100644 --- a/JotunnModStub/Factions/FactionMerchantCatalog.cs +++ b/JotunnModStub/Factions/FactionMerchantCatalog.cs @@ -72,7 +72,7 @@ namespace RacesOfValheim new CatalogEntry("DeerHide", 2), new CatalogEntry("DeerMeat", 2), new CatalogEntry("LeatherScraps", 5), - new CatalogEntry("BoarMeat", 5), + new CatalogEntry("RawMeat", 5), // was "BoarMeat" - not a real prefab id, never appeared new CatalogEntry("NeckTail", 5), new CatalogEntry("TrophyNeck", 20), new CatalogEntry("TrophyDeer", 20), @@ -94,7 +94,7 @@ namespace RacesOfValheim new CatalogEntry("LoxPelt", 2), new CatalogEntry("Flax", 5), new CatalogEntry("Barley", 5), - new CatalogEntry("Cloudberries", 5), + new CatalogEntry("Cloudberry", 5), // was "Cloudberries" - not a real prefab id, never appeared new CatalogEntry("Tar", 5), // Growth, folded in here: Growth lives in Plains, same biome as Lox/Ocean new CatalogEntry("Tuna", 50), new CatalogEntry("CoralCod", 70), @@ -240,7 +240,7 @@ namespace RacesOfValheim { "Troll", TrollShop }, - { "Fuling", FulingShop }, + { "Goblin", FulingShop }, // "Goblin" is the real prefab id - "Fuling" is only the in-game display name { "GoblinBrute", FulingShop }, { "GoblinShaman", FulingShop }, diff --git a/JotunnModStub/Furling/FurlingPatches.cs b/JotunnModStub/Furling/FurlingPatches.cs index 8e0167c..9895050 100644 --- a/JotunnModStub/Furling/FurlingPatches.cs +++ b/JotunnModStub/Furling/FurlingPatches.cs @@ -62,8 +62,8 @@ namespace RacesOfValheim if (otherChar != null) { string name = otherChar.gameObject.name.Replace("(Clone)", "").ToLower(); - if (name == "goblin" || - name == "goblinbrute" || + if (name == "goblin" || + name == "goblinbrute" || name == "goblinshaman" || name == "lox" || name == "deathsquito" || diff --git a/README.md b/README.md index 95e1354..5f444b1 100644 --- a/README.md +++ b/README.md @@ -204,6 +204,7 @@ Please write to us on my Discord server: **https://discord.gg/gbBEK2VTE** - **Skeleton**: Fixed a bug where a helmet or beard could stay visible even while the race's own head-hiding was active. - **Skeleton**: Your chosen race now shows correctly on the main-menu character preview. - **Skeleton**: The burning skull (Moder tier+) no longer sheds a lit torch that falls to the ground - the flame's clone is stripped down to just the particles and light it actually needs. +- **Factions**: The base Goblin (in-game display name "Fuling") wasn't actually covered by Black Forest peace or trading for any race - the code used the display name "Fuling" instead of the real prefab id "Goblin". Trenta, Trol and Furling now get real peace with it, and it trades like every other Black Forest mob. **v1.3.12** - **Skadi**: Dragon flight reworked. The stasis that holds a form level after you stop powering now lasts 5 seconds instead of 2. Hold Shift with W to spend 15 stamina a second on a burst of speed - the only part of flight that costs anything, since the drake arrives at The Elder long before you could pay just to stay airborne, and running dry drops you back to normal speed rather than out of the sky. S beats backwards along your aim, pitch included: look down and press it to rise away from whatever you are watching, without turning to face away from it.