fix(prefabs): replace every lookup name that does not exist in vanilla
An audit of all 59 prefab names the mod resolves, against the game's own
asset manifests, found nine that are not in Valheim at all. A name vanilla
does not use has no vanilla candidate to beat in Jotunn's name cache, so it
is a free slot for whoever ships one - which is how another mod's weapon
trail became the Skeleton's fire aura in 00d4fd6.
Eight of the nine failed in silence, which is why none of them was ever
reported:
vfx_corpse_destruction -> _medium, _large for the Muspell. The puff that
covers a transformation. Fenrir and Skadi at least had their sparks;
the Muspell swapped bodies in plain view with nothing at all.
vfx_surtling_death -> vfx_wraith_death for the Aswid's Mist Form,
which reads as mist by construction and is the same creature the form
already borrows its Visual from; vfx_corpse_destruction_medium for the
thrall, where nothing is misty. Vanilla has no surtling death effect
under any spelling.
TrophyTroll -> TrophyForestTroll.
TrophyBat -> TrophyDeathsquito. Vanilla ships no bat trophy,
so the Aswid's two status effects and its radial entry had no icon.
vfx_smoke -> gone. It was the Trenta's fallback for Purple
Rain's particle material behind Greydwarf_Shaman, and the day the
Shaman failed to resolve it would have worn whatever a mod supplies.
Purple Rain is purple by design, so nobody would ever have reported it.
The ninth did not fail in silence. vfx_OozeHit was passed to Instantiate
unguarded, so every successful Draugh parry threw ArgumentException and took
the North Wind nova below it down as well. It is vfx_blob_hit.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
00d4fd6e46
commit
e75c7072c4
10 changed files with 65 additions and 14 deletions
|
|
@ -708,7 +708,17 @@ namespace RacesOfValheim
|
|||
{
|
||||
isTransformingSequence = true;
|
||||
|
||||
GameObject poofPrefab = Jotunn.Managers.PrefabManager.Cache.GetPrefab<GameObject>("vfx_surtling_death");
|
||||
// WAS "vfx_surtling_death", WHICH IS NOT A PREFAB IN THIS GAME. The surtling has no
|
||||
// death effect under any spelling, so this resolved to nothing and the Mist Form has
|
||||
// always appeared and disappeared with no puff at all - both here and in
|
||||
// RevertMistFormRoutine. Kept as a note rather than a fallback: a name vanilla does not
|
||||
// use is a free slot for any mod that ships one, which is how another mod's weapon trail
|
||||
// became the Skeleton's fire aura (see SkeletonVisuals.EnsureFireAura).
|
||||
//
|
||||
// The Wraith's own death effect reads as mist by construction, which is what this wanted,
|
||||
// and it is already the right creature: the form borrows the Wraith's Visual a few lines
|
||||
// below. If the look wants changing, that effect is the thing to alter.
|
||||
GameObject poofPrefab = Jotunn.Managers.PrefabManager.Cache.GetPrefab<GameObject>("vfx_wraith_death");
|
||||
if (poofPrefab != null) Instantiate(poofPrefab, Player.m_localPlayer.transform.position, Quaternion.identity);
|
||||
|
||||
Player.m_localPlayer.GetSEMan().AddStatusEffect("SE_MistForm".GetStableHashCode(), true);
|
||||
|
|
@ -763,7 +773,9 @@ namespace RacesOfValheim
|
|||
{
|
||||
isTransformingSequence = true;
|
||||
|
||||
GameObject poofPrefab = Jotunn.Managers.PrefabManager.Cache.GetPrefab<GameObject>("vfx_surtling_death");
|
||||
// The same puff as going in - see TransformIntoMistRoutine for why the old name never
|
||||
// resolved to anything.
|
||||
GameObject poofPrefab = Jotunn.Managers.PrefabManager.Cache.GetPrefab<GameObject>("vfx_wraith_death");
|
||||
if (poofPrefab != null) Instantiate(poofPrefab, Player.m_localPlayer.transform.position, Quaternion.identity);
|
||||
|
||||
Transform playerVisual = Player.m_localPlayer.transform.Find("Visual");
|
||||
|
|
|
|||
|
|
@ -114,13 +114,13 @@ namespace RacesOfValheim
|
|||
{
|
||||
var aswidStats = ScriptableObject.CreateInstance<SE_AswidStats>();
|
||||
aswidStats.name = "SE_AswidStats";
|
||||
aswidStats.m_icon = PrefabManager.Cache.GetPrefab<ItemDrop>("TrophyBat")?.m_itemData.m_shared.m_icons[0];
|
||||
aswidStats.m_icon = PrefabManager.Cache.GetPrefab<ItemDrop>("TrophyDeathsquito")?.m_itemData.m_shared.m_icons[0];
|
||||
|
||||
ItemManager.Instance.AddStatusEffect(new CustomStatusEffect(aswidStats, fixReference: false));
|
||||
|
||||
var batForm = ScriptableObject.CreateInstance<SE_BatForm>();
|
||||
batForm.name = "SE_BatForm";
|
||||
batForm.m_icon = PrefabManager.Cache.GetPrefab<ItemDrop>("TrophyBat")?.m_itemData.m_shared.m_icons[0];
|
||||
batForm.m_icon = PrefabManager.Cache.GetPrefab<ItemDrop>("TrophyDeathsquito")?.m_itemData.m_shared.m_icons[0];
|
||||
|
||||
ItemManager.Instance.AddStatusEffect(new CustomStatusEffect(batForm, fixReference: false));
|
||||
|
||||
|
|
|
|||
|
|
@ -117,7 +117,10 @@ namespace RacesOfValheim
|
|||
m_ai.SetFollowTarget(user.gameObject);
|
||||
}
|
||||
|
||||
GameObject vfx = ZNetScene.instance.GetPrefab("vfx_surtling_death");
|
||||
// "vfx_surtling_death" was asked for here and is not a prefab in this game, so dominating
|
||||
// a creature happened with no effect at all. The generic body-sized puff, rather than the
|
||||
// Wraith's mist the Mist Form wears: nothing about domination is misty.
|
||||
GameObject vfx = ZNetScene.instance.GetPrefab("vfx_corpse_destruction_medium");
|
||||
if (vfx) Instantiate(vfx, m_character.transform.position, Quaternion.identity);
|
||||
|
||||
user.Message(MessageHud.MessageType.Center, $"{m_character.m_name} dominated!");
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue