Commit graph

4 commits

Author SHA1 Message Date
Ferdinando
6e87be3c77 minor bugfix and pad support 2026-09-12 10:42:01 +02:00
Ferdinando
03c1006511 fix(butler): the cook's lost meat, the furnace that starved, the coal with nowhere to go
Three tester reports against the Bone Servant, all with the same shape:
the servant was doing what the code said and the code said the wrong
thing. Two vanilla methods were re-read off the IL rather than trusted.

RPC_RemoveDoneItem empties ONE slot per call - it finds the first Done
slot, spawns its item, clears it and returns - not every slot, as the
comment on PullOutput claimed. DoCollect also swept the ground BEFORE
pulling, so each visit collected the previous visit's item and dropped a
fresh one; since Plan() diverts to PlanDelivery the moment the payload is
non-empty, the servant then left for the chest and abandoned what it had
just pulled. A working hearth therefore always had exactly one cooked
meat lying beside it. Now it pulls first, in a loop bounded by a new
ButlerStation.OutputPulls - the slot count for a cooking station, 1
everywhere else, because the fermenter's Ready survives its own tap for
the length of the animation and a bare while(HasOutput) would spam
RPC_Tap.

PlanFuel sat last, behind PlanLoad, and FreeSlots goes back above zero
the instant a furnace eats one ore - so loading always had an answer and
refuelling never got a turn. The blast furnace burned down to nothing.
PlanFuel now runs ahead of PlanLoad, which cannot starve loading in
return because FuelWanted is 0 for a station with no work, and it scores
candidates by the walk the way PlanLoad does now that the choice matters.

PlanDelivery offers the load to the nearest station that will CONSUME it,
as material or as fuel, after the chest search fails and before dropping
it on the floor. UpdateSmelter only calls SpawnProcessed once the ore
queue empties, so the charcoal kiln releases its whole batch at once -
exactly the delivery a nearly full chest cannot absorb. The coal now
walks into the furnace beside it instead of onto the ground.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-29 08:45:09 +02:00
e042579e17 Fix Bone Servant crash when dropping a payload it can't place
DropPayload() cloned template.m_itemData straight off the ObjectDB
prefab and handed the clone to ItemDrop.DropItem, which instantiates
item.m_dropPrefab - a field a clone off a raw prefab never carries
(same pitfall already fixed in AswidBloodPotions.MakeFood). The result
was an unhandled ArgumentException instantiating null.

This fires whenever a servant is holding something with nowhere sealed
to put it - e.g. chests without the sigil item yet, as in the bug
report - and since the exception aborts before m_payload.Clear() runs,
the same broken load is retried, and crashes, on every AI tick after:
relogging or killing the servant doesn't clear it, because the payload
lives in the ZDO, not the character.

Fix: set clone.m_dropPrefab = prefab before dropping, same as the
existing fix.
2026-08-25 22:48:30 +02:00
Ferdinando
0aa1dc4dc8 warvulture 2026-08-16 07:44:44 +02:00