Commit graph

1 commit

Author SHA1 Message Date
11fd68757a fix(skills): honour "no skill loss" for every skill, not just the level
Death runs Skills.OnDeath, which is only

    LowerAllSkills(m_DeathLowerFactor * Game.m_skillReductionRate)

and the world modifier works by driving that rate to zero. LowerAllSkills then
takes nothing off m_level, as intended - but it also wipes m_accumulator on
every skill and prints "$msg_skills_lowered" unconditionally, whatever the
factor. So a death on a no-skill-loss world still quietly threw away all the
progress banked toward the next level and still announced a loss.

On a skill sitting just short of the next level that is indistinguishable from
losing one, which is how this surfaced on Blood Magic - the skill the Aswid
gains fastest, and so the one most often near a boundary.

The guard is on the factor rather than on any race, so it holds for every skill
and every race, and a world with a partial death penalty is left alone. It logs
the factor and the world rate on each death, since a death that lowers nothing
and a death that lowers something are otherwise identical from in-game.
2026-08-04 00:22:30 +02:00