Commit graph

13 commits

Author SHA1 Message Date
5bdd7200a5 fix(fenrir): the Ulv no longer asks the player for feet called LeftHand
The form's CharacterAnimEvent finds its FootStep on the nearest Character
up the hierarchy, which for a form parented under the player is the player.
The Ulv's Run clip names its front paws LeftHand and RightHand, a human rig
has neither, and vanilla logged "FAiled to find foot" twice per stride.

The form's receivers are now cut from the player's FootStep, on the local
form and on the copy other players see. The footsteps stay: the hidden
human animator keeps running and FootStep steps off its curve.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-26 18:17:37 +02:00
9907cae292 fix(fenrir): give the forms a voice, and stop the sounds writing to the save
Every sound the Fenrir forms played was looked up by a name, and most of
those names are not prefabs in this game. The chains hid it: PlaySFX walks
its arguments and stops at the first that resolves, so a claw that asked for
"sfx_fenring_attack", "sfx_fenring_attack_claw", "sfx_wolf_attack" had a
Fenring swinging with a wolf's voice through a fallback nobody noticed. The
cultist's double claw asked for three dead names in a row and was silent from
the day it was written.

The creatures do have their own sounds. The forms now use them:
sfx_fenring_claw_start for the swing, sfx_fenring_claw_hit for the landing,
sfx_fenring_fireclaw to open the fire breath. The Ulv keeps the wolf's, since
vanilla ships it nothing but sfx_ulv_death.

THE HOWL WAS NEVER A PREFAB TO LOOK UP. It is an AnimationEvent inside the
wolf's 'C_Hawl' clip, firing at 0.39s with the sound handed over as an object
reference - and a player in wolf form idles through that clip and howls out
loud already, with the game's own AnimationEffect doing the work. Three
spellings of one word are why this took so long to find: the clip is
'C_Hawl', the sound is 'sfx_wolf_haul', and the mod was looking for
'sfx_wolf_howl', the only correct spelling of the three and the only one that
does not exist. The Fenring has no howl of its own at all, so it borrows the
wolf's over its Taunt.

The jump attack's impact moved to where the jump lands, next to the damage,
instead of firing before the dash while the form is still standing.

FenrirCreatureSound.Spawn is the other half. Some vanilla sound prefabs carry
a ZNetView - sfx_fenring_alerted does - and one that wakes with no init ZDO
writes a persistent record into the world, once per swing. Spawning now runs
inside ZNetView.StartGhostInit, the game's own answer, so no ZDO is made. All
nine sound spawns in these forms go through it.

sfx_fenring_howl resolves to an ordinary sound prefab and hard-exits the
process when spawned on its own. It is named in a Suspect set, described in
the log and never instantiated, because a name nobody records is a name
somebody adds back.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 00:20:31 +02:00
e75c7072c4 fix(prefabs): replace every lookup name that does not exist in vanilla
An audit of all 59 prefab names the mod resolves, against the game's own
asset manifests, found nine that are not in Valheim at all. A name vanilla
does not use has no vanilla candidate to beat in Jotunn's name cache, so it
is a free slot for whoever ships one - which is how another mod's weapon
trail became the Skeleton's fire aura in 00d4fd6.

Eight of the nine failed in silence, which is why none of them was ever
reported:

  vfx_corpse_destruction  ->  _medium, _large for the Muspell. The puff that
      covers a transformation. Fenrir and Skadi at least had their sparks;
      the Muspell swapped bodies in plain view with nothing at all.
  vfx_surtling_death      ->  vfx_wraith_death for the Aswid's Mist Form,
      which reads as mist by construction and is the same creature the form
      already borrows its Visual from; vfx_corpse_destruction_medium for the
      thrall, where nothing is misty. Vanilla has no surtling death effect
      under any spelling.
  TrophyTroll             ->  TrophyForestTroll.
  TrophyBat               ->  TrophyDeathsquito. Vanilla ships no bat trophy,
      so the Aswid's two status effects and its radial entry had no icon.
  vfx_smoke               ->  gone. It was the Trenta's fallback for Purple
      Rain's particle material behind Greydwarf_Shaman, and the day the
      Shaman failed to resolve it would have worn whatever a mod supplies.
      Purple Rain is purple by design, so nobody would ever have reported it.

The ninth did not fail in silence. vfx_OozeHit was passed to Instantiate
unguarded, so every successful Draugh parry threw ArgumentException and took
the North Wind nova below it down as well. It is vfx_blob_hit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 00:20:02 +02:00
Ferdinando
9bebcf340b bugfix 24/09/26 2026-09-24 10:30:39 +02:00
58f70f1a4c Merge branch 'war-vulture' into main
Brings in the Sverm race, the War Vulture flying mount, and Skadi's
Crystal Golem (replacing the Hidden Hollow). Resolved conflicts:
AswidVisuals.cs took war-vulture's skeleton-eye-light rewrite with
main's attach/attack/sleep timing guard re-applied on top, and
RaceCompendium.cs kept main's rewritten race entries while folding in
war-vulture's Sverm/War Vulture pages and the new Claws paragraphs for
Aswid and Fenrir.
2026-08-11 20:35:48 +02:00
Ferdinando
1c4b20bb06 warvulture 2026-08-11 19:29:58 +02:00
25795a05e9 fix(input): abilities no longer die while a movement key is held
BepInEx's KeyboardShortcut.IsDown() ends in ModifierKeyTest, which
requires that no key outside the shortcut is currently held - it only
exempts the mouse buttons. That is right for a config-menu hotkey and
wrong for a game ability: holding W (or any other movement key) made
every bound ability in the mod stop responding, for every race, mouse
bindings included. Vanilla attacks kept working because they go
through ZInput, which is what made it look like a Skadi/dragon bug.

Adds RaceInput.IsDownIgnoringHeldKeys / IsPressedIgnoringHeldKeys -
main key down plus every modifier held, without the blocking rule -
and switches all 27 call sites across Aswid, Dvergar, Fenrir, Skadi,
Trenta and Trol over to them.

Arrived with the rebindable-keybind work that shipped in 1.4.0.
2026-08-09 12:33:41 +02:00
Ferdinando
5c5b8c34d2 feat(races): Skadi hollow chain, plus the pending Dvergar and Fenrir ones
Three per-race item chains had accumulated uncommitted. They land
together because FactionMerchantCatalog.cs carries hunks from all
three and cannot be split without interactive staging.

Skadi (new this session):
- SkadiNokkel - "Skadis Nokkel", a StaffSkeleton clone recoloured to
  ice, stripped of its eitr and health costs and of the skeleton
  summon, opening an ice-blue portal to a troll cave the player
  claims as their own. Crafted at the forge after Moder from a
  1500-coin Greater Frost Heart, a DragonTear and a TrophySkeleton.
- SkadiFrostHeart - the bought leg of that recipe, sold by the
  Cultist bench.
- SkadiHollow / SkadiHollowPortal - claims one existing TrollCave02
  in the Black Forest, half a world radius out and south of the
  equator, and opens a linked local portal pair to it.
- RaceCaveBuilding - Skadi and Trol may build inside any troll cave.

Two facts worth keeping, both paid for the hard way:
- a troll cave counts as a DUNGEON, so the flag that refuses a piece
  there is the per-piece Piece.m_allowedInDungeons, not the
  per-location Location.m_noBuild. Player.m_placementStatus names the
  exact refusal reason and is now logged.
- Object.DestroyImmediate is forbidden inside an animation event
  callback, and a staff cast runs in one - it fails silently there.

Also carried in, from earlier sessions and unverified in game:
- Dvergar contract bank and barrel (DvergarBanco*, DvergarBotte*)
- Fenrir Ulvsblod trough (FenrirMangiatoia*)
- the Wolf -> Ulv merchant bench move, so tameable wolves stop
  answering the E key with a shop window

Status: compiles clean with no new warnings. The Skadi chain has NOT
been confirmed working in game - the most recent fix to the troll
cave detection is still untested.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-08 14:58:43 +02:00
6755c263f3 feat(fenrir): make ability numbers and keybinds BepInEx-configurable
Adds FenrirConfig.cs, following the established per-race pattern: one
Configuration Manager section per topic (Keybinds, Passive Combat, Form
Buffs, and one per transformation form - Fenring, Cultist, Wolf, Ulv),
covering every attack's damage/radius/push-force number across all four
independent form behaviors, plus the four transform/howl keybinds.
Defaults match the previous hardcoded constants exactly.

Only the four transform/howl keys are rebindable - unlike Skadi's dragon
forms, which share one unified attack-button scheme, each of Fenrir's
four forms is an independent MonoBehaviour with its own hardcoded mouse
reads, so making all eleven attack buttons rebindable was left out as a
much larger, separately-scoped change.

The Form Buffs section opens with a non-editable note (the CustomDrawer
trick from ConfigurationManagerAttributes) explaining that those specific
values are baked into status effects once at mod startup and need a
relog to pick up a change - everything else reads live.

Config sections stay bound alphabetically by race (Aswid, Draugh,
Dvergar, Fenrir, Skadi) in RacesOfValheim.Awake().
2026-08-06 14:12:07 +02:00
668a017a91 fix(fenrir): hide the human body in every form, not just shrink it
Wolf, Ulv, Fenring and Cultist all hid the player by scaling the Visual child
to a thousandth of its size. That has quietly stopped working: the scale reset
that keeps a non-Trol player at normal height runs from a postfix on the same
update and puts the scale straight back to 1, so the man reappeared standing
inside his own wolf a frame after transforming. Fenrir is not one of the races
listed as sizing itself, so nothing exempted it from that reset.

Use PlayerVisualHider, the same fix Skadi and the Aswid already carry: renderers
go off with forceRenderingOff and are re-swept periodically, so nothing that
touches the transform can undo it, and the Animator is never disabled - which is
what made reverting look like respawning back when this was solved for the
dragon forms.

Both the local form and the copy other players see are switched over; the remote
path in ZdoVisualSync used the same scale trick and had the same bug.
2026-08-05 11:05:25 +02:00
Ferdinando
1dbfbd02b6 fix(aswid): center Vampiric Aura on the caster and stop transforms from casting the real Guardian Power
Vampiric Aura was centered 2m in front of the player instead of on
them, and its Blood Magic scaling only ever added up to +1 damage at
level 100; rebalanced to a 1 base + up to 5 scaled split.

Aswid Bat Form, Skadi Cold Spell, Skadi Drake/Moder Form and Fenrir
Wolf Form all borrow the native "gpower" animator trigger for its
arms-raised casting pose. That clip carries a baked-in Animation Event
that calls Player.ActivateGuardianPower(), which fired regardless of
who triggered the animation - borrowing it silently cast the player's
real Guardian Power (and burned its cooldown) whenever one was
available. Added a brief, time-based suppression window in RaceInput
around each borrowed trigger so only that one call is swallowed.

Also includes AswidSpectralClaw.cs, a boss-scaled bare-fist damage
item for Aswid, currently disabled pending equip-state fixes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-03 21:37:58 +02:00
bca47beda6 Ignore race ability input while a GUI has focus
UnityEngine.Input reads the device directly, so abilities bound to keys
or mouse buttons kept firing with the map, the inventory, a chest, the
chat or a menu open - clicking an item in a container also swung the
transformed attack.

Route that input through Player.TakeInput, which is what Valheim runs
its own controls through and already reports false for those states
(InventoryGui covers the backpack and chests alike). Aswid's transform
keys were the only place already doing this; the shared helper replaces
that one-off and covers Skadi's cold spell, form keys, flight toggle,
form attacks and flight boost, Fenrir's form keys and the attacks of all
four form behaviors, Trol's rock throw and true form, and Aswid's devour
toggle.

Cultist fire is a held button, so it is gated per read rather than
around the block: opening a GUI mid-stream now falls through to
StopFire() instead of leaving the flames running.
2026-08-01 13:25:02 +02:00
Ferdinando
c4a24c9fdf Initial commit 2026-07-30 19:00:13 +02:00