UnityEngine.Input reads the device directly, so abilities bound to keys
or mouse buttons kept firing with the map, the inventory, a chest, the
chat or a menu open - clicking an item in a container also swung the
transformed attack.
Route that input through Player.TakeInput, which is what Valheim runs
its own controls through and already reports false for those states
(InventoryGui covers the backpack and chests alike). Aswid's transform
keys were the only place already doing this; the shared helper replaces
that one-off and covers Skadi's cold spell, form keys, flight toggle,
form attacks and flight boost, Fenrir's form keys and the attacks of all
four form behaviors, Trol's rock throw and true form, and Aswid's devour
toggle.
Cultist fire is a held button, so it is gated per read rather than
around the block: opening a GUI mid-stream now falls through to
StopFire() instead of leaving the flames running.
Flight ran on the debug-fly noclip, so it ignored aim entirely and needed
Space/Ctrl for height. It now uses Character's native flying-creature
movement with the camera's full look direction fed in each frame:
- Aim steers, including climb and dive; W powers forward, releasing it
holds level briefly and then settles into a glide instead of coasting
along the aim vector (which let you climb forever without input).
- The body actually turns now. m_flyTurnSpeed sat at Character's 12 deg/s
default because the Player prefab was never set up to fly, so a quarter
turn took over seven seconds and read as no rotation at all.
- Touching down no longer slides you forward forever. Zeroing the fly
speeds stops the character without fighting the AddForce UpdateFlying
queues, which had caused frame-to-frame jitter and TAA ghosting.
DurationMinutes was never wired to anything, so timed forms never expired
and their cooldown, which only starts on reversion, was unreachable in
practice. Timed forms now drop on their own, and both the remaining time
and the cooldown show up beside the minimap as a Moder trophy icon.
Attack capability was snapshotted when the form was entered, so reaching
the Bonemass tier while already transformed left the drake unarmed until
the player reverted and transformed again; it is re-read live now.