Commit graph

28 commits

Author SHA1 Message Date
d9bca1934f fix(skills): hand-built attacks level the skill they scale with
Form attacks and powers called Damage directly, and vanilla only raises
a skill inside Attack and Projectile.OnHit, so the skill never moved.
FormMelee.RaiseSkill pays once per swing or tick that hit a creature.

- Fenrir forms' claws and bites: Unarmed; Cultist fire: Elemental Magic
- Skadi drake melee and Trenta stomp: Unarmed
- Aswid aura: Blood Magic, 0.1 per second like the Frost Aura
- Alfar Geisli and Ljosstorm: Elemental Magic; Sameining pulse 0.1/s
- Trenta Purple Rain scales with Blood Magic (two new bonus keys) and
  levels it once per cast that reaches someone besides the caster
2026-11-06 21:21:11 +01:00
c5387421d4 fix: Cultist breath pose holds, roar loops, Cultist stands still
The creature's CharacterAnimEvent resets Animator.speed to 1 every physics step
outside a vanilla attack, so the speed-0 pin never held: the pose is now replayed
at the pin each frame. The flame ZSFX loops without its fade-out. While breathing
the player is held still through FenrirForms.LocalAttacking (no walking cast clip
exists); the howl waits for the breath to end.
2026-10-29 14:24:04 +01:00
a6df7a47f8 fix: Cultist breath holds the throw pose and keeps its flames
Pin at 1.3 s, the throw, instead of 2.6 s, where the vanilla Cultist has already
lowered its arms. fx_fenring_flames is a one-throw effect (2 s non-looping
emitters, 5 s TimedDestruction): loop the emitters and drop the timer so the
flames last the whole hold.
2026-10-29 14:14:24 +01:00
d142fad330 fix: Cultist fire from the hands, tied to its clip, facing the camera
The breath waits for the flame clip's Hit point (1.245 s), holds the casting pose
while the button is held and blends back to Movement on release, so a short click
no longer leaves the arms raised for the clip's 3.5 s. Eitr drains from the
flames on. Each fx_fenring_flames emitter follows its hand bone. While breathing,
Player.AlwaysRotateCamera answers true, so the body turns to the camera as when
blocking. Onlookers' copies follow the same clip.
2026-10-29 14:00:26 +01:00
beffd0bee6 fix: a stagger cancels the form's attack
A form swing waits for its clip's hit event and lands on a timeout if none comes,
so a stagger that cut the clip short still dealt the blow. Attacks are marked as
they start (TrySpendStamina, Ravager AttackRoutine) and their hits are dropped if
a stagger began since. No attack or Cultist breath starts while staggered.
2026-10-29 13:53:04 +01:00
62ebc13116 Merge branch 'feat-form-attack-stamina': Form attacks cost stamina 2026-10-29 13:22:45 +01:00
3dae107b85 fix(fenrir): the Cultist's flames leave its mouth
The breath effect was placed 1.5 m above the player's feet and 1 m
ahead, chest height on a Cultist and the same whatever the form's size.

It now sits on the form's Jaw bone (fenring_cultist rig: Neck/Head/Jaw,
read from the game files), 0.3 m ahead, Head as the second choice and
the old fixed point if neither exists. A small follower places it every
LateUpdate, facing where the player faces, on the owner's copy and on
every onlooker's. The burn area is unchanged.
2026-10-29 02:30:05 +01:00
ac4ce4c636 feat(forms): Trol True Form and Fenrir form attacks cost stamina
Every form swing was free. FormMelee.TrySpendStamina charges a form
attack the way Attack.GetAttackStamina charges a weapon: equipment
modifier, status effects, up to a third off with the skill. Short of
stamina, the attack does not start and the bar flashes.

Trol True Form (Clubs skill), priced by the troll's damage, the slam
dearer for hitting all around: punch 10, side log swing 10, overhead
log 12, ground slam 18.

Fenrir forms (Unarmed), cheaper than weapons: Fenring 6/10/16, Wolf
4/6/10, Ulv 5/8/14, Cultist claw 6 and double claw 12. In exchange each
form hit gives 1.5x adrenaline (Fenrir - Form Buffs / Form Adrenaline
Multiplier), in Fenrir forms only.

Every cost is its own config entry beside the attack's damage.
2026-10-29 02:28:23 +01:00
ffb45d1c1c fix(fenrir): Cultist claws land on the clip's own hits
The single claw dealt its damage at a fixed 0.4 s, before the swing in
ClawAttackCultist (Hit event at 0.64 s of 1.33 s), and released the lock
at 0.5 s, so clicking again started a new claw mid-swing. The double
claw dealt one hit at 0.6 s although DoubleClawAttackCultist swipes
twice (Hit events at 0.64 s and 1.21 s).

BlockPlayerAttackTriggerPatch now counts the form's Hit events
(FenrirForms.AttackEvents) instead of only swallowing them. Both claws
wait for their events, with a timeout, and hold the lock until the clip
ends. Each double-claw swipe deals 60% of Double Claw Damage, 120% in
all for a slower swing that can be cut short.
2026-10-29 02:23:27 +01:00
d8dcecb573 fix(fenrir): form hits build adrenaline like a weapon hit
Vanilla grants a hit's adrenaline inside Attack. The forms skip Attack
and call Damage directly, so only the stagger bonus in Character.Damage
reached the player: meadow mobs, quick to stagger, filled the bar, while
Lox, Tar, Brutes and Furlings gave nothing until staggered.

FormMelee.GrantAdrenaline adds the player's unarmed attack adrenaline
times the target's multiplier after each claw or bite, and a fifth of
it per 0.2s tick of the Cultist's fire.
2026-10-23 22:17:17 +02:00
96dc8e4158 fix(fenrir): Ulv sleeps on the sit key; forms stand still to attack
Humanoid.IsSitting asks about the "sitting" animator tag, which belongs
to chairs. The sit key is an emote that Player.StartEmote writes on the
ZDO as "sit", so the Ulv never saw the player sit down. FormLocomotion
now reads the ZDO emote too, which every client sees. Of the four
forms only ulv_animator has a sleeping state.

The hidden player kept walking under the form through an attack, so a
bite slid toward whatever WASD held. Each form's isAttacking now also
sets FenrirForms.LocalAttacking, and a SetControls prefix holds the
player still while it is set, as the True Form troll does. The leaps
move the body directly and are untouched. Cleared on every revert.
2026-10-17 19:01:03 +02:00
580ef6d468 feat(fenrir): forms sneak at a walk and sleep when the player sits
FormLocomotion zeroed the speed whenever the player crouched, so a
sneaking form slid across the ground in its idle pose. Only airborne
reads as still now: crouched, the player moves at sneaking speed and
the creature's controller picks its walk.

Sitting sets the "sleeping" bool the creature's own MonsterAI uses,
when its controller has one; the log says once per controller which do.
IsSitting reads the replicated animator state, so onlookers' copies
sleep too. Covers every Fenrir form, local and remote, and the True
Form troll, which share FormLocomotion. Mirror now takes the Player.

Requested by a player on Discord.
2026-10-17 18:51:14 +02:00
Ferdinando
553303d0fd bugfix 06/10/26 + bone ship 2026-10-06 11:36:18 +02:00
b4b6fe3758 fix(fenrir): hidden human no longer attacks or blocks under a form
The attack block patched Character.StartAttack, which Humanoid overrides
without calling the base, so it never ran; and it covered the Fenring only.
Every form swing also fired the hidden human's attack: stamina spent,
regen held at zero while it played, and forward_speed dropped to 0. Patch
Humanoid.StartAttack for all four forms, and clear m_blocking after
SetControls so the pad's heavy attack stops raising the guard.

Forms treat the player as airborne only after 0.25 s off the ground, so
bumps no longer flicker run to idle. Melee reach ignores the target's own
colliders and accepts a clear line from the eyes or the attack point, with
an opt-in hit log. Sunrise names the key that still works by day.
2026-09-28 22:19:37 +02:00
b0d18b0654 feat(text): on-screen messages come from translation files
Every message the mod puts in the middle or corner of the screen now reads
its text through ModText.Get, and messages.json holds 191 texts in English
and Italian. Values computed in code become $1, $2 in the text, so a
translator can put them wherever the sentence needs them. Branching
messages get one key per branch.

A few messages travel through a field before they are shown: thralls'
refusals and the building limits now hold a token or key there. Boss and
form names inside messages use tokens too, the bosses the game's own, so
"The Elder" arrives translated.

ModText.Get now localizes each argument before inserting it. A token
argument left for a later pass ran into the text after it: "$1's power"
became the unknown token "enemy_eikthyr's".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-26 20:30:03 +02:00
0674329592 fix(fenrir): spawn sounds the way vanilla spawns effects, without ghost init
Ghost init was meant to keep a sound's ZNetView from writing a ZDO. It
does not: ZNetView.Awake still creates the ZDO and only skips registering
the instance, so ZNetScene sees an unbuilt ZDO and builds a second copy.
Vanilla's EffectList.Create uses a plain Instantiate, and TimedDestruction
deletes the ZDO through ZNetScene.Destroy when the sound ends. The spawn
now does the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-26 18:50:51 +02:00
7ad1d6920e fix(fenrir): the Ulv was mouthing a silent howl
The howl code took a playing animation as proof the sound was coming, because
the wolf's does bring it: 'C_Hawl' fires an Effect event at 0.39s holding
sfx_wolf_haul. The Ulv is the same family on the same rig and its 'Idle Howl'
carries no event at all - events=0, read straight off dumpanim - so pressing
the key as an Ulv played the animation and nothing else. The muzzle went up in
silence.

Which creatures bring their own sound is now written down rather than assumed,
and it is only the wolf. FenrirCreatureSound.Howl does the whole thing -
animation, trigger published for the other clients, and a sound unless the
animation is already carrying one - so the four forms call one line and the
distinction lives in one place.

The Ulv's hold also went from 3.3s to 3.8s: it was the wolf's clip length,
copied, and 'Idle Howl' runs 3.67s.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 16:55:19 +02:00
6b43d3544e feat(fenrir): say why the fire breath did not come, and log a Draugh's parry
Holding right mouse as a Cultist with no eitr did nothing whatsoever - no
flames, no sound, no reason given. The form arrives at Yagluth and eitr is a
Mistlands thing, so a Cultist meets that silence before it ever meets the
fire. It now says "Only breath comes out. The fire wants eitr." on a
three-second timer, since the button is read every frame and the message would
otherwise be a wall.

The parry that fires the Draugh's poison splash is logged, with the block
timer against the window and whether the splash effect resolved. A parry has
to land inside a quarter-second window while blocking, so "nothing looks
different after tier 3" is as likely to mean the window was missed as it is to
mean the splash did not draw, and there was no way to tell those apart.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 14:00:21 +02:00
da896179fd feat(fenrir): howl on demand, in every form
The howl key was only ever read by the two Fenring forms. As a wolf or an Ulv
it did nothing at all - not a misconfiguration, the classes simply never
looked at it. All four forms read it now.

The wolf and the Ulv perform the creature's own howl animation and NO SOUND
IS SPAWNED, because their clip already carries one: 'C_Hawl' fires an
animation event at 0.39s holding sfx_wolf_haul, and the game's own
AnimationEffect plays it. The audio comes out of the animation, at the
instant the animation means it to, which no prefab fired on a keypress can
match. Spawning one as well would be a second howl over the first.

A trigger is looked for before a state, and that is about multiplayer rather
than tidiness: FenrirAttackSync replicates trigger names, so a howl fired
through a trigger is one the other clients see and hear, while Animator.Play
is local and nobody else knows. Which route was taken is logged once per
creature, and if neither exists the log prints the animator's whole parameter
list rather than leaving another keypress that quietly does nothing.

The Fenring and the Cultist have no howl clip in vanilla - 19 and 18 clips,
none of them a howl, and their taunt fires no sound event - so they keep the
Taunt animation and take the wolf's howl as their voice.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 01:41:00 +02:00
9907cae292 fix(fenrir): give the forms a voice, and stop the sounds writing to the save
Every sound the Fenrir forms played was looked up by a name, and most of
those names are not prefabs in this game. The chains hid it: PlaySFX walks
its arguments and stops at the first that resolves, so a claw that asked for
"sfx_fenring_attack", "sfx_fenring_attack_claw", "sfx_wolf_attack" had a
Fenring swinging with a wolf's voice through a fallback nobody noticed. The
cultist's double claw asked for three dead names in a row and was silent from
the day it was written.

The creatures do have their own sounds. The forms now use them:
sfx_fenring_claw_start for the swing, sfx_fenring_claw_hit for the landing,
sfx_fenring_fireclaw to open the fire breath. The Ulv keeps the wolf's, since
vanilla ships it nothing but sfx_ulv_death.

THE HOWL WAS NEVER A PREFAB TO LOOK UP. It is an AnimationEvent inside the
wolf's 'C_Hawl' clip, firing at 0.39s with the sound handed over as an object
reference - and a player in wolf form idles through that clip and howls out
loud already, with the game's own AnimationEffect doing the work. Three
spellings of one word are why this took so long to find: the clip is
'C_Hawl', the sound is 'sfx_wolf_haul', and the mod was looking for
'sfx_wolf_howl', the only correct spelling of the three and the only one that
does not exist. The Fenring has no howl of its own at all, so it borrows the
wolf's over its Taunt.

The jump attack's impact moved to where the jump lands, next to the damage,
instead of firing before the dash while the form is still standing.

FenrirCreatureSound.Spawn is the other half. Some vanilla sound prefabs carry
a ZNetView - sfx_fenring_alerted does - and one that wakes with no init ZDO
writes a persistent record into the world, once per swing. Spawning now runs
inside ZNetView.StartGhostInit, the game's own answer, so no ZDO is made. All
nine sound spawns in these forms go through it.

sfx_fenring_howl resolves to an ordinary sound prefab and hard-exits the
process when spawned on its own. It is named in a Suspect set, described in
the log and never instantiated, because a name nobody records is a name
somebody adds back.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-26 00:20:31 +02:00
Ferdinando
9bebcf340b bugfix 24/09/26 2026-09-24 10:30:39 +02:00
Ferdinando
834d6647fd chore(release): v1.4.19 - eye height, remote forms, food refresh, faction retaliation
Race body scale moved the model and not the camera: Character.m_eye hangs
off the unscaled root, so a Trol or a Dvergar changed height for everyone
but themselves. RaceEyeHeight moves the eye by whatever scale the Visual
is wearing, for every player, so aim rays follow too.

Remote copies of a Fenrir form had no one writing to their Animator and
stood in the controller's default state, sliding. RemoteFenrirAnimator
mirrors the four local behaviours off the player's own replicated
animator, the way RemoteSkadiAnimator already did for Skadi.

Player.Food.m_time is time remaining, not time elapsed: the Aswid, Trenta
and Draugh repeat-meal branches all set it to 0 and expired the slot they
meant to renew, and left the nutrition values stale. RaceFoodRefresh does
what vanilla's own branch does, in one place instead of three. The Trenta
prefix now reports __result, or a working refresh would have renewed the
slot without consuming the seed.

Aswid devour was gated by one timestamp shared by every corpse, so a pack
killed at once fed the player once; it is now per corpse, floored at a
second, and a refused meal says $msg_nomore.

MonsterAI.UpdateTarget discards any target IsEnemy refuses, so a truced
mob could not retaliate at all - it stood still or fled. RaceGrudge
records the hit on the AI owner's client and both truce postfixes stand
down for that pair. The Aswid drain and the Skadi frost aura now skip
kin, as the Skeleton's fire aura already did, or an always-on aura would
hold every truce permanently broken.

Faction sets matched exact prefab names with families half-listed:
added Skeleton_NoArcher and Draugr_Ranged to the Swamp, Greyling to the
Black Forest.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-20 08:26:22 +02:00
Ferdinando
ce671e7124 jotunn 2.30 compatibility + minor bugs 2026-09-10 19:14:05 +02:00
10e55aff3e fix(fenrir): source the taunt howl from the real creature's alert bark
sfx_wolf_howl/sfx_wolf_alert/sfx_fenring_idle never resolved to anything
playable - wolves carry no standalone howl prefab. Reads
BaseAI.m_alertedEffects off the live Fenring/Fenring_Cultist prefabs
instead, the same effect the creature itself plays going on alert.

Still reported silent in testing; leaving it in as a step in the right
direction rather than reverting.
2026-08-09 18:31:33 +02:00
25795a05e9 fix(input): abilities no longer die while a movement key is held
BepInEx's KeyboardShortcut.IsDown() ends in ModifierKeyTest, which
requires that no key outside the shortcut is currently held - it only
exempts the mouse buttons. That is right for a config-menu hotkey and
wrong for a game ability: holding W (or any other movement key) made
every bound ability in the mod stop responding, for every race, mouse
bindings included. Vanilla attacks kept working because they go
through ZInput, which is what made it look like a Skadi/dragon bug.

Adds RaceInput.IsDownIgnoringHeldKeys / IsPressedIgnoringHeldKeys -
main key down plus every modifier held, without the blocking rule -
and switches all 27 call sites across Aswid, Dvergar, Fenrir, Skadi,
Trenta and Trol over to them.

Arrived with the rebindable-keybind work that shipped in 1.4.0.
2026-08-09 12:33:41 +02:00
6755c263f3 feat(fenrir): make ability numbers and keybinds BepInEx-configurable
Adds FenrirConfig.cs, following the established per-race pattern: one
Configuration Manager section per topic (Keybinds, Passive Combat, Form
Buffs, and one per transformation form - Fenring, Cultist, Wolf, Ulv),
covering every attack's damage/radius/push-force number across all four
independent form behaviors, plus the four transform/howl keybinds.
Defaults match the previous hardcoded constants exactly.

Only the four transform/howl keys are rebindable - unlike Skadi's dragon
forms, which share one unified attack-button scheme, each of Fenrir's
four forms is an independent MonoBehaviour with its own hardcoded mouse
reads, so making all eleven attack buttons rebindable was left out as a
much larger, separately-scoped change.

The Form Buffs section opens with a non-editable note (the CustomDrawer
trick from ConfigurationManagerAttributes) explaining that those specific
values are baked into status effects once at mod startup and need a
relog to pick up a change - everything else reads live.

Config sections stay bound alphabetically by race (Aswid, Draugh,
Dvergar, Fenrir, Skadi) in RacesOfValheim.Awake().
2026-08-06 14:12:07 +02:00
bca47beda6 Ignore race ability input while a GUI has focus
UnityEngine.Input reads the device directly, so abilities bound to keys
or mouse buttons kept firing with the map, the inventory, a chest, the
chat or a menu open - clicking an item in a container also swung the
transformed attack.

Route that input through Player.TakeInput, which is what Valheim runs
its own controls through and already reports false for those states
(InventoryGui covers the backpack and chests alike). Aswid's transform
keys were the only place already doing this; the shared helper replaces
that one-off and covers Skadi's cold spell, form keys, flight toggle,
form attacks and flight boost, Fenrir's form keys and the attacks of all
four form behaviors, Trol's rock throw and true form, and Aswid's devour
toggle.

Cultist fire is a held button, so it is gated per read rather than
around the block: opening a GUI mid-stream now falls through to
StopFire() instead of leaving the flames running.
2026-08-01 13:25:02 +02:00
Ferdinando
c4a24c9fdf Initial commit 2026-07-30 19:00:13 +02:00