The eye frame was read from the head bone's pose ON THE FRAME THE EYES WERE BUILT, snapped to the nearest axis, then cached for the life of the eyes. Catch the head a few degrees into a turn and the snap picks the neighbouring axis, and the pair stays wrong until something rebuilds it. Each race met this separately and each added the same guard - do not build while attached, mid-attack or asleep - which caught the loud cases and left the quiet one: a race change rebuilds while the rig is still settling, which is none of those three. That is why resetting into a race could break the placement while logging out and back in silently fixed it. The logout was never a fix, only a rebuild at a calmer moment, and no fourth guard condition would have closed it - the read itself had to stop depending on when it happens. sharedMesh.bindposes[headBone] is the rig as authored: no animation in it, no timing, the same answer on frame one and frame ten thousand. A rebuild is now deterministic and a bad moment cannot exist. Falls back to the live read, warning once, on a rig that carries no bind pose. Lives in one shared RigBindPose rather than in three copies. The three eye implementations are separate files by design - they differ in what they hang and how it is coloured - but this is the one piece of maths where a divergence would be a bug in whichever copy got fixed second, and it had already been fixed twice. The three now-dead private SnapToAxis copies go with it. Also updates the Aswid eye defaults to the values dialled in on screen: forward 0.013, height 0.004, yaw 22.068.
113 lines
6.4 KiB
C#
113 lines
6.4 KiB
C#
using UnityEngine;
|
|
|
|
namespace RacesOfValheim
|
|
{
|
|
/// <summary>
|
|
/// Which way a player's skull faces, in the head bone's own coordinates, taken from the rig as
|
|
/// it was AUTHORED rather than from the pose it happens to hold this frame.
|
|
///
|
|
/// THE BUG THIS EXISTS TO KILL. Three races hang something on the head bone - the Aswid's
|
|
/// borrowed sockets, the Dvergar's and the Sverm's spheres - and all three need to know which
|
|
/// local axis points forward and which points up before they can place it. The obvious way to
|
|
/// ask is headBone.InverseTransformDirection(player.transform.forward), and it works right up
|
|
/// until it does not: that reads the head WHERE IT IS STANDING THIS FRAME, the answer is then
|
|
/// snapped to the nearest axis, and the result is cached for as long as the eyes exist. Catch
|
|
/// the head a few degrees into a turn and the snap picks the neighbouring axis instead, and the
|
|
/// eyes stay wrong until something happens to rebuild them.
|
|
///
|
|
/// Each race met this separately and each added the same guard - do not build while attached,
|
|
/// mid-attack or asleep - which caught the loud cases and left the quiet one. A race change
|
|
/// rebuilds while the rig is still settling, which is none of those three, so resetting into a
|
|
/// race could break the placement while logging out and back in - a rebuild at a calmer moment -
|
|
/// silently fixed it. That is not a bug that a fourth condition fixes. The read itself has to
|
|
/// stop depending on when it happens.
|
|
///
|
|
/// THE BIND POSE DOES NOT MOVE. SkinnedMeshRenderer.sharedMesh.bindposes[i] is the matrix that
|
|
/// takes a direction out of the renderer's own space and into bone i's local space, as the
|
|
/// model was rigged - no animation in it, no timing, the same answer on frame one and on frame
|
|
/// ten thousand. Measured from there, a rebuild is deterministic and a bad moment cannot exist.
|
|
///
|
|
/// ONE COPY, THREE CALLERS, deliberately. The three eye implementations are otherwise each
|
|
/// their own file by design - they differ in what they hang and how it is coloured - but this
|
|
/// is the one piece of maths where a divergence would be a bug in whichever copy got fixed
|
|
/// second, and it has already been fixed twice.
|
|
/// </summary>
|
|
public static class RigBindPose
|
|
{
|
|
/// <summary>
|
|
/// Fills in the skull's own forward, up and right. Always produces a usable answer: where
|
|
/// the rig carries no bind pose it falls back to reading the live pose, which is the old
|
|
/// behaviour and its old caveat, said out loud once rather than silently.
|
|
/// </summary>
|
|
public static void MeasureHeadFrame(Player player, Transform headBone, string raceTag,
|
|
out Vector3 localForward, out Vector3 localUp, out Vector3 localRight)
|
|
{
|
|
VisEquipment visEq = player != null ? player.GetComponent<VisEquipment>() : null;
|
|
SkinnedMeshRenderer body = visEq != null ? visEq.m_bodyModel : null;
|
|
Mesh mesh = body != null ? body.sharedMesh : null;
|
|
|
|
if (mesh != null && body.bones != null && mesh.bindposes != null && mesh.bindposes.Length > 0)
|
|
{
|
|
int index = System.Array.IndexOf(body.bones, headBone);
|
|
if (index >= 0 && index < mesh.bindposes.Length)
|
|
{
|
|
// The player's own forward and up, put into the renderer's space first - that is
|
|
// where a bindpose starts from. The renderer's own transform is not animated
|
|
// (the bones under it are), so this half is stable too.
|
|
Vector3 forwardInRenderer = body.transform.InverseTransformDirection(player.transform.forward);
|
|
Vector3 upInRenderer = body.transform.InverseTransformDirection(player.transform.up);
|
|
|
|
Matrix4x4 toBone = mesh.bindposes[index];
|
|
localForward = SnapToAxis(toBone.MultiplyVector(forwardInRenderer).normalized);
|
|
localUp = SnapToAxis(toBone.MultiplyVector(upInRenderer).normalized);
|
|
localRight = Vector3.Cross(localUp, localForward).normalized;
|
|
return;
|
|
}
|
|
}
|
|
|
|
WarnOnce(raceTag);
|
|
|
|
Transform root = player.transform;
|
|
localForward = SnapToAxis(headBone.InverseTransformDirection(root.forward));
|
|
localUp = SnapToAxis(headBone.InverseTransformDirection(root.up));
|
|
localRight = Vector3.Cross(localUp, localForward).normalized;
|
|
}
|
|
|
|
private static readonly System.Collections.Generic.HashSet<string> warned =
|
|
new System.Collections.Generic.HashSet<string>();
|
|
|
|
private static void WarnOnce(string raceTag)
|
|
{
|
|
if (!warned.Add(raceTag ?? "?")) return;
|
|
|
|
Jotunn.Logger.LogWarning(
|
|
$"[{raceTag}] No bind pose for the head bone on this rig, so the facing is being read " +
|
|
"from the live pose instead. That read can land while the head is mid-turn and leave " +
|
|
"the eyes off the face until they are rebuilt.");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Rounds a direction to the nearest of the six axis directions. Whichever component is
|
|
/// largest wins, sign included.
|
|
///
|
|
/// The raw measurement arrives tilted - a "forward" leaning 20 degrees down puts the eyes on
|
|
/// the jaw instead of the eye line - and a bone's real axes are square, so the tilt is
|
|
/// nothing but noise and is rounded away.
|
|
///
|
|
/// Right is never snapped by callers, only derived: rounding all three independently
|
|
/// guarantees nothing about the angles between them, and a "right" that shares an axis with
|
|
/// forward stops being sideways - the separation then pushes one eye out of the face and
|
|
/// pulls the other into it. A cross product cannot be anything but perpendicular.
|
|
/// </summary>
|
|
public static Vector3 SnapToAxis(Vector3 direction)
|
|
{
|
|
float x = Mathf.Abs(direction.x);
|
|
float y = Mathf.Abs(direction.y);
|
|
float z = Mathf.Abs(direction.z);
|
|
|
|
if (x >= y && x >= z) return new Vector3(Mathf.Sign(direction.x), 0f, 0f);
|
|
if (y >= z) return new Vector3(0f, Mathf.Sign(direction.y), 0f);
|
|
return new Vector3(0f, 0f, Mathf.Sign(direction.z));
|
|
}
|
|
}
|
|
}
|