fix(factions): use the real 'Goblin' prefab id, not the display name 'Fuling'

FactionHostilityPatch's NeraForestaMobs set and FactionMerchantCatalog's
Shops dictionary both keyed the base Goblin by its in-game display name,
"Fuling", instead of its actual prefab id. Confirmed against the game's own
asset paths (Assets/Characters/Goblin/, TrophyGoblin.prefab) rather than
assumption - "Fuling" appears nowhere as a real prefab, only as flavor text
(kept as-is on the shop's own DisplayName, which is just UI label text).

Neither peace nor merchant status ever actually applied to a plain Goblin
for any Black Forest race (Trenta, Trol, Furling) as a result - only the
GoblinBrute/GoblinShaman entries, which already used their real ids, worked.

Confirmed a related but separate bug while investigating, left alone per
request: AswidRace.cs's mobToTrophyMap also keys off "Fuling" and feeds it
into a live prefab lookup for food nutrition tuning - same wrong-id pattern,
milder failure mode (falls back to generic values rather than breaking
anything). Not fixed here.
This commit is contained in:
kanym 2026-08-07 11:32:13 +02:00
commit 9287bd060d
4 changed files with 7 additions and 6 deletions

View file

@ -20,7 +20,7 @@ namespace RacesOfValheim
private static readonly HashSet<string> NeraForestaMobs = new HashSet<string> private static readonly HashSet<string> NeraForestaMobs = new HashSet<string>
{ {
"Greydwarf", "Greydwarf_Elite", "Greydwarf_Shaman", "Greydwarf", "Greydwarf_Elite", "Greydwarf_Shaman",
"Fuling", "GoblinBrute", "GoblinShaman", "Goblin", "GoblinBrute", "GoblinShaman", // "Goblin" is the real prefab id - "Fuling" is only the in-game display name
"Troll", "Troll",
}; };

View file

@ -72,7 +72,7 @@ namespace RacesOfValheim
new CatalogEntry("DeerHide", 2), new CatalogEntry("DeerHide", 2),
new CatalogEntry("DeerMeat", 2), new CatalogEntry("DeerMeat", 2),
new CatalogEntry("LeatherScraps", 5), new CatalogEntry("LeatherScraps", 5),
new CatalogEntry("BoarMeat", 5), new CatalogEntry("RawMeat", 5), // was "BoarMeat" - not a real prefab id, never appeared
new CatalogEntry("NeckTail", 5), new CatalogEntry("NeckTail", 5),
new CatalogEntry("TrophyNeck", 20), new CatalogEntry("TrophyNeck", 20),
new CatalogEntry("TrophyDeer", 20), new CatalogEntry("TrophyDeer", 20),
@ -94,7 +94,7 @@ namespace RacesOfValheim
new CatalogEntry("LoxPelt", 2), new CatalogEntry("LoxPelt", 2),
new CatalogEntry("Flax", 5), new CatalogEntry("Flax", 5),
new CatalogEntry("Barley", 5), new CatalogEntry("Barley", 5),
new CatalogEntry("Cloudberries", 5), new CatalogEntry("Cloudberry", 5), // was "Cloudberries" - not a real prefab id, never appeared
new CatalogEntry("Tar", 5), // Growth, folded in here: Growth lives in Plains, same biome as Lox/Ocean new CatalogEntry("Tar", 5), // Growth, folded in here: Growth lives in Plains, same biome as Lox/Ocean
new CatalogEntry("Tuna", 50), new CatalogEntry("Tuna", 50),
new CatalogEntry("CoralCod", 70), new CatalogEntry("CoralCod", 70),
@ -240,7 +240,7 @@ namespace RacesOfValheim
{ "Troll", TrollShop }, { "Troll", TrollShop },
{ "Fuling", FulingShop }, { "Goblin", FulingShop }, // "Goblin" is the real prefab id - "Fuling" is only the in-game display name
{ "GoblinBrute", FulingShop }, { "GoblinBrute", FulingShop },
{ "GoblinShaman", FulingShop }, { "GoblinShaman", FulingShop },

View file

@ -204,6 +204,7 @@ Please write to us on my Discord server: **https://discord.gg/gbBEK2VTE**
- **Skeleton**: Fixed a bug where a helmet or beard could stay visible even while the race's own head-hiding was active. - **Skeleton**: Fixed a bug where a helmet or beard could stay visible even while the race's own head-hiding was active.
- **Skeleton**: Your chosen race now shows correctly on the main-menu character preview. - **Skeleton**: Your chosen race now shows correctly on the main-menu character preview.
- **Skeleton**: The burning skull (Moder tier+) no longer sheds a lit torch that falls to the ground - the flame's clone is stripped down to just the particles and light it actually needs. - **Skeleton**: The burning skull (Moder tier+) no longer sheds a lit torch that falls to the ground - the flame's clone is stripped down to just the particles and light it actually needs.
- **Factions**: The base Goblin (in-game display name "Fuling") wasn't actually covered by Black Forest peace or trading for any race - the code used the display name "Fuling" instead of the real prefab id "Goblin". Trenta, Trol and Furling now get real peace with it, and it trades like every other Black Forest mob.
**v1.3.12** **v1.3.12**
- **Skadi**: Dragon flight reworked. The stasis that holds a form level after you stop powering now lasts 5 seconds instead of 2. Hold Shift with W to spend 15 stamina a second on a burst of speed - the only part of flight that costs anything, since the drake arrives at The Elder long before you could pay just to stay airborne, and running dry drops you back to normal speed rather than out of the sky. S beats backwards along your aim, pitch included: look down and press it to rise away from whatever you are watching, without turning to face away from it. - **Skadi**: Dragon flight reworked. The stasis that holds a form level after you stop powering now lasts 5 seconds instead of 2. Hold Shift with W to spend 15 stamina a second on a burst of speed - the only part of flight that costs anything, since the drake arrives at The Elder long before you could pay just to stay airborne, and running dry drops you back to normal speed rather than out of the sky. S beats backwards along your aim, pitch included: look down and press it to rise away from whatever you are watching, without turning to face away from it.